Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cursor style #1596

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Add Cursor style #1596

merged 13 commits into from
Oct 8, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Aug 14, 2024

No description provided.

features/cursor-style.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,47 @@
name: Cursor Style
description: The `cursor` CSS property styles the pointer, allowing you to provide hints to the user on how to interact with the hovered element.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good description! Succinct and talks about an actual use case (which is not always possible). 👍

Comment on lines 14 to 15
safari: ≤13.1
safari_ios: ≤13.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Across the board, caniuse says that Safari doesn't support this feature but BCD says it does. See Fyrd/caniuse#7066. I've filed mdn/browser-compat-data#24142 to see if that can/should be fixed. I think this PR is going to be blocked for a little bit until we've figured who's correct.

(I'll wait for triage on BCD to see if it's correctable soon—if not, we can turn this into a draft feature so the PR doesn't have to be held open for forever.)

# firefox_android: "95"
# safari: "5"
# safari_ios: "4.2"
- css.properties.cursor.none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to this point, these are off by one version for Edge when compared to caniuse. I'm not worried about this since it's pre-2020, but I did note it in: #1499.

Comment on lines 5 to 6
- css3-cursors
- css3-cursors-newer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on the results of mdn/browser-compat-data#24142, we may want to include https://caniuse.com/css3-cursors-grab too.

@ddbeck ddbeck added the blocked Blocked waiting for something external label Aug 16, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 25, 2024

Now waiting on mdn/browser-compat-data#24387.

@jamesnw jamesnw removed the blocked Blocked waiting for something external label Oct 2, 2024
@jamesnw
Copy link
Collaborator Author

jamesnw commented Oct 2, 2024

@ddbeck I updated the dist with the updated BCD info, but it removed a lot of baseline support due to Safari iOS being dropped. I picked a compute_from to match Caniuse css-cursors, but am now wondering if I should remove the css-cursors-newer and css-cursors-grab which don't match.

@jamesnw jamesnw requested a review from ddbeck October 2, 2024 17:59
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 7, 2024

@ddbeck I updated the dist with the updated BCD info, but it removed a lot of baseline support due to Safari iOS being dropped.

Yes, I think that's right—you shouldn't expect this all to work on all platforms. Odd but true.

I picked a compute_from to match Caniuse css-cursors, but am now wondering if I should remove the css-cursors-newer and css-cursors-grab which don't match.

I think we should remove the compute_from completely and let it go. The headline status will be correct with respect to all three caniuse features. If you want to be especially careful, then you could add a TODO comment linking back to #1038. This feels like one of those features that you can "just" use without worrying about the implications on mobile and we ought to be able to communicate that fact.

@jamesnw
Copy link
Collaborator Author

jamesnw commented Oct 7, 2024

@ddbeck I updated the dist with the updated BCD info, but it removed a lot of baseline support due to Safari iOS being dropped.

Yes, I think that's right—you shouldn't expect this all to work on all platforms. Odd but true.

I picked a compute_from to match Caniuse css-cursors, but am now wondering if I should remove the css-cursors-newer and css-cursors-grab which don't match.

I think we should remove the compute_from completely and let it go. The headline status will be correct with respect to all three caniuse features. If you want to be especially careful, then you could add a TODO comment linking back to #1038. This feels like one of those features that you can "just" use without worrying about the implications on mobile and we ought to be able to communicate that fact.

@ddbeck Makes sense. I've removed the compute_from and added a TODO.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 8e9b783 into web-platform-dx:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants