-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cursor style #1596
Add Cursor style #1596
Conversation
features/cursor-style.yml
Outdated
@@ -0,0 +1,47 @@ | |||
name: Cursor Style | |||
description: The `cursor` CSS property styles the pointer, allowing you to provide hints to the user on how to interact with the hovered element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good description! Succinct and talks about an actual use case (which is not always possible). 👍
features/cursor-style.yml.dist
Outdated
safari: ≤13.1 | ||
safari_ios: ≤13.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Across the board, caniuse says that Safari doesn't support this feature but BCD says it does. See Fyrd/caniuse#7066. I've filed mdn/browser-compat-data#24142 to see if that can/should be fixed. I think this PR is going to be blocked for a little bit until we've figured who's correct.
(I'll wait for triage on BCD to see if it's correctable soon—if not, we can turn this into a draft feature so the PR doesn't have to be held open for forever.)
features/cursor-style.yml.dist
Outdated
# firefox_android: "95" | ||
# safari: "5" | ||
# safari_ios: "4.2" | ||
- css.properties.cursor.none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to this point, these are off by one version for Edge when compared to caniuse. I'm not worried about this since it's pre-2020, but I did note it in: #1499.
features/cursor-style.yml
Outdated
- css3-cursors | ||
- css3-cursors-newer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on the results of mdn/browser-compat-data#24142, we may want to include https://caniuse.com/css3-cursors-grab too.
Now waiting on mdn/browser-compat-data#24387. |
@ddbeck I updated the dist with the updated BCD info, but it removed a lot of baseline support due to Safari iOS being dropped. I picked a compute_from to match Caniuse |
Yes, I think that's right—you shouldn't expect this all to work on all platforms. Odd but true.
I think we should remove the |
@ddbeck Makes sense. I've removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
No description provided.