fix: should catch onTestCaseResult rpc timeout error
#661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds timeout error handling for RPC method calls in the worker runtime. When RPC methods timeout, custom error messages are now logged to help with debugging.
- Added
onTimeoutErrorhandler to the birpc configuration - Passes
originalConsoletocreateRuntimeRpcto ensure error messages can be logged even when console is intercepted
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/runtime/worker/rpc.ts | Implements onTimeoutError handler with custom error messages for onTestCaseResult and onConsoleLog RPC methods, adds originalConsole parameter |
| packages/core/src/runtime/worker/index.ts | Captures original console reference and passes it to createRuntimeRpc |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
onTestCaseResult/onConsoleLogRPC timeout error should be captured because it will not affect the test. Use the logged error instead of the test's unhandled rejection error.before:
after:
Related Links
Checklist