fix: should catch process.kill error correctly
#660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds protection against test code accidentally killing the worker process by intercepting process.kill calls. Similar to the existing process.exit interceptor, this change throws an error when tests attempt to kill the current process, preventing unexpected worker termination.
Key changes:
- Added
process.killoverride that throws an error when targeting the current process ID - Updated test to verify the new error handling behavior
- Refactored test assertions to use helper functions (
expectExecFailed,expectLog)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/runtime/worker/index.ts | Intercepts process.kill calls targeting the current process and throws descriptive errors |
| e2e/runner/test/processKill.test.ts | Updated test assertions to verify process.kill interception and use helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should catch
process.killerror correctly.before:
after:
Related Links
Checklist