Skip to content

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Sep 11, 2025

Summary

support coverage.reportsDirectory option.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 11, 2025 07:00
@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 0eeac6b
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/68c2745c5d2edc00082d2071
😎 Deploy Preview https://deploy-preview-557--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a configurable coverage.reportsDirectory option to allow users to specify where coverage reports should be generated, defaulting to './coverage'.

  • Adds reportsDirectory field to coverage configuration types
  • Updates the Istanbul coverage provider to use the configured directory
  • Implements proper path resolution for both relative and absolute paths

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/coverage-istanbul/src/provider.ts Updates coverage provider to use configurable reports directory and imports proper type
packages/core/src/types/coverage.ts Adds reportsDirectory option to coverage types and imports proper CoverageMap type
packages/core/src/config.ts Adds default reportsDirectory value and path resolution logic
packages/core/package.json Adds istanbul-lib-coverage types dependency
e2e/test-coverage/index.test.ts Adds test for custom reportsDirectory functionality
e2e/test-coverage/fixtures/rstest.reportsDirectory.config.ts Test configuration for custom reports directory
e2e/projects/fixtures/rstest.coverage.config.ts Coverage configuration for projects test
e2e/projects/fixtures/package.json Package dependencies for projects test
e2e/projects/coverage.test.ts Test coverage functionality in projects context
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@9aoy 9aoy merged commit d7a086a into main Sep 11, 2025
16 checks passed
@9aoy 9aoy deleted the coverage-reportsDirectory branch September 11, 2025 07:25
@9aoy 9aoy mentioned this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant