Skip to content

fix: correctly display build error messages #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jun 20, 2025

Summary

Use stats.compilation.errors.splice instead of filter & reassign to avoid communication problems with Rust -> JS -> Rust.

This is actually a bug in rspack and is not easy to fix at the moment.

now:
image

expect:
image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 120b59b
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/68552132ef63db0008a7a95f
😎 Deploy Preview https://deploy-preview-302--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@9aoy 9aoy merged commit 189ef3d into main Jun 20, 2025
15 checks passed
@9aoy 9aoy deleted the fix/build-error-message branch June 20, 2025 09:07
@9aoy 9aoy mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant