Skip to content

fix: empty blockquote crash the compiler #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Conversation

zoolsher
Copy link
Contributor

Summary

Fixing the bug #2220 by adding undefined protection to a part of logic in plugin-container-syntax.

Related Issue

#2220

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 29, 2025

Deploy Preview for rspress-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6838646c6acbb26f24da2d25

Copy link

netlify bot commented May 29, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 4e783e4
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/68385fa282b6f2000884e953
😎 Deploy Preview https://deploy-preview-2221--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@zoolsher zoolsher requested a review from JounQin May 29, 2025 13:27
@zoolsher zoolsher enabled auto-merge (squash) May 29, 2025 13:30
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks❤️

@zoolsher zoolsher merged commit 64ad2ae into main May 29, 2025
7 of 12 checks passed
@zoolsher zoolsher deleted the fix/crash-on-empty-blockquote branch May 29, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants