Skip to content

fix: children should be unavailable for CodeBlockRuntime #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented May 26, 2025

Summary

image

Related Issue

related #2190

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 26, 2025

Deploy Preview for rspress-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 03ddb0c
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6834216afedbe70008f4f7f7

1 similar comment
Copy link

netlify bot commented May 26, 2025

Deploy Preview for rspress-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 03ddb0c
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6834216afedbe70008f4f7f7

@SoonIter SoonIter merged commit 0233244 into web-infra-dev:main May 26, 2025
4 of 9 checks passed
@SoonIter
Copy link
Member

could title be optional?

And we also need a shikiOptions to pass shiki options

https://preview.fumadocs.dev/docs/ui/components/dynamic-codeblock

@JounQin JounQin deleted the fix/CodeBlockRuntime branch May 26, 2025 09:49
@JounQin
Copy link
Collaborator Author

JounQin commented May 26, 2025

could title be optional?

It's already optional.

And we also need a shikiOptions to pass shiki options

OK, I'll raise another PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants