Skip to content

chore: remove htmr dep #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented May 22, 2025

Summary

remove htmr dep

Related Issue

N/A

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 22, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 796a0ee
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/682f2342c27283000815a597
😎 Deploy Preview https://deploy-preview-2191--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 22, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 796a0ee
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/682f23425fb80e000918d3cb
😎 Deploy Preview https://deploy-preview-2191--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@SoonIter
Copy link
Member

This is not a lossless change because there is an additional span level.

Could we use some of the code here of dom api to remove this span ?

https://github.com/pveyes/htmr/blob/master/src/index.browser.ts

@JounQin
Copy link
Collaborator Author

JounQin commented May 23, 2025

This is not a lossless change because there is an additional span level.

Could we use some of the code here of dom api to remove this span ?

pveyes/htmr@master/src/index.browser.ts

Then why not just continue using htmr?

The new CodeBlockRuntime also has an additional div wrapper.

@JounQin
Copy link
Collaborator Author

JounQin commented May 30, 2025

@SoonIter In case that we've already included rehype related tools due to CodeBlockRuntime/shiki, I think we should use rehype-parse + hast-to-jsx-runtime instead, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants