-
Notifications
You must be signed in to change notification settings - Fork 170
fix: sidebar type=file with data-context #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4162846
to
8152046
Compare
Can you please open an issue/discussion first to describe what are you trying to resolve? I have no idea what you're doing, no summary, no related issue nor reference. |
Certainly! I've created an issue and updated the summary for this pull request. |
thanks ❤~ |
Summary
The
div.rspress-sidebar-item
and the finalLink
component were initially implemented separately, causing certain cases to be overlooked, as shown in the test cases. Here's what I've done to address this issue:div.rspress-sidebar-item
andLink
components to prevent any oversights.Related Issue
issue:#2202
Checklist