Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): failed to run preview with TS config file #9468

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 26, 2025

Summary

This PR fixes the failure of rspack preview' to run with rspack.config.ts'.

The preview command should inherit all common CLI flags to have the default value of --configLoader.

fix #9460

related #9210

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 26, 2025
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 80920d7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bea44dcb6a3f000819dc1c

Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9468 will not alter performance

Comparing preview_with_ts_config_0226 (80920d7) with main (9a6473c)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@chenjiahan chenjiahan changed the title fix(CLI): failed to run preview with ts config file fix(cli): failed to run preview with ts config file Feb 26, 2025
@chenjiahan chenjiahan changed the title fix(cli): failed to run preview with ts config file fix(cli): failed to run preview with TS config file Feb 26, 2025
@chenjiahan chenjiahan requested a review from 9aoy February 26, 2025 06:03
@chenjiahan chenjiahan merged commit fa2bae1 into main Feb 26, 2025
35 checks passed
@chenjiahan chenjiahan deleted the preview_with_ts_config_0226 branch February 26, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "npx rspack preview" not working after version 1.2.3
2 participants