refactor: rename async_run to background_run & sync_run to main_run #8385
+25
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sync_run
is actually a async function now, so thesync_run
name is kind of awkward, whatasync_run
andsync_run
actually means issync_run
: can only be running in main thread(the thread drives task_loop), cause it can exclusively access mutable global stateasync_run
: can be running in background threadsso I think run_in_main_thread and run_in_backgrund_thread is more accurate, but it's too verbose
so change
sync_run
tomain_run
andasync_run
tobackground_run
I'm open to better name cause I don't think these two names are perfect
Checklist