feat: throw error for outdated compilation #8315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team
✅ Deploy Preview for rspack canceled.
|
|
!eco-ci |
ahabhgk
previously approved these changes
Nov 4, 2024
h-a-n-a
reviewed
Nov 4, 2024
h-a-n-a
reviewed
Nov 4, 2024
h-a-n-a
reviewed
Nov 4, 2024
|
Looks good. Would you please add a test case for the error message to avoid future regression? |
SyMind
force-pushed
the
throw-error-for-last-compilation
branch
from
4287f65
to
d603430
Compare
h-a-n-a
changed the title
h-a-n-a
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Rspack compilation instance will be dropped on the Rust side after the compilation stage.
Before this PR, since the memory address of the compilation instance on the Rust side didn't change across multiple compilation cycles, when properties and methods on an outdated compilation instance on the JavaScript side were called, the data from the current Rust instance was retrieved, which was not as expected.
Now, Rspack will throw an error when an outdated JavaScript side compilation instance is accessed.
The compilation instance of Rspack will be dropped on the Rust side after compilation.
Checklist