fix: error for set user request #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!eco-ci |
github-actions
bot
added
team
✅ Deploy Preview for rspack canceled.
|
SyMind
force-pushed
the
fix-set-user-request
branch
from
ab2631f
to
22af7a7
Compare
ahabhgk
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In monaco-editor-webpack-plugin, a new value is set for module.userRequest to avoid a bug in the NamedModulesPlugin.
See webpack/webpack#4613 (comment) for details
However, the NamedModulesPlugin is outdated, and internally,
Rspack doesn't depend on module.userRequest to generate the identifier of the module.
Checklist