fix: types and docs of umd external object #8286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
relate to #8248
Cause the external object value can only be used when libraryTarget or externalTarget is
umd
, and if it will throw error whencommonjs
orcommonjs2
orroot
is not set. So we can use zod to validate the external object value.The
amd
field is optional because it can generatedefine([])
when not set, but there is a bug here in rspack that generateddefine([null])
. This pr also fix it.Not close the issue because when libraryTarget is not
umd
, the external object value is also valid but will generate a wired code. For example,libraryTarget: "var"
andreact: { root: "React", commonjs: "react" }
will generatevar external_react_root_react_commonjs_react = undefined
which can not actually work.So we may need a better validation here to check
libraryTarget
andexternals
.Checklist