Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add JSDoc to improve config.performance #8231

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

GiveMe-A-Name
Copy link
Member

Summary

Zod types system is not easy to understand by user.

We tend use raw ts provider intellisense and jsDoc for user in ide.

  • Add JSDoc for config.performance

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 20b62bd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671ef5ee4547e60008fa795e

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan enabled auto-merge (squash) October 28, 2024 02:32
@chenjiahan chenjiahan merged commit 29d4b87 into main Oct 28, 2024
29 checks passed
@chenjiahan chenjiahan deleted the refactor/configuration-performance branch October 28, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants