Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep SWC types up to date #8215

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: keep SWC types up to date #8215

merged 1 commit into from
Oct 25, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 24, 2024

Summary

SWC now provides a separate @swc/types package, so that Rspack can extend the official types instead of maintaining all types.

https://github.com/swc-project/swc/tree/main/packages/types

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan
Copy link
Member Author

!eco-ci

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 1d1044c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671a4e36e2927900083b3120

@rspack-bot
Copy link

rspack-bot commented Oct 24, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@chenjiahan
Copy link
Member Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Oct 24, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@chenjiahan chenjiahan merged commit 1b3ad8c into main Oct 25, 2024
36 checks passed
@chenjiahan chenjiahan deleted the swc_types_1024 branch October 25, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants