refactor: import module hooks #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
|
!eco-ci |
JSerFeng
force-pushed
the
fix/import-module-hooks
branch
from
22281a1
to
5d0cba7
Compare
|
!eco-ci |
JSerFeng
force-pushed
the
fix/import-module-hooks
branch
from
5d0cba7
to
d81cabf
Compare
JSerFeng
force-pushed
the
fix/import-module-hooks
branch
2 times, most recently
from
2001073
to
1dfb7d4
Compare
ahabhgk
previously approved these changes
Sep 25, 2024
JSerFeng
force-pushed
the
fix/import-module-hooks
branch
from
1dfb7d4
to
a8d9a1b
Compare
ahabhgk
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
import module should use different plugin_driver compare to main compilation, so that plugins won't operate incorrect compilation
Checklist