feat(core): add Yarn PnP support #7639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
release: feature
Contributor
Author
|
!bench |
|
⏳ Triggered benchmark: Open |
hardfist
commented
Aug 21, 2024
hardfist
commented
Aug 21, 2024
h-a-n-a
reviewed
Aug 21, 2024
hardfist
commented
Aug 21, 2024
packages/rspack-test-tools/tests/configCases/resolve/pnp/.yarn/install-state.gz
Show resolved
Hide resolved
arcanis
reviewed
Aug 21, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump"). |
Contributor
|
Bump, I still have it in my backlog (I've been in on-and-off paternity leave since August, so my bandwidth has been limited - but I'm still very interested to bring it to the finish line). |
Contributor
Author
thank you, we'll continue investigating yarn pnp support |
|
This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump"). |
|
bump |
hardfist
force-pushed
the
yj/pnp-support
branch
2 times, most recently
from
d14db9f to
43b4278
Compare
hardfist
force-pushed
the
yj/pnp-support
branch
from
43b4278 to
3eaae99
Compare
chenjiahan
reviewed
Jan 9, 2025
chenjiahan
reviewed
Jan 9, 2025
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
chenjiahan
approved these changes
Jan 9, 2025
chenjiahan
changed the title
|
nice work!!! |
This was referenced Jan 17, 2025
chenjiahan
added a commit
that referenced
this pull request
Jan 24, 2025
Cyberboss
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Apr 12, 2025
## About The Pull Request Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now ## Why It's Good For The Game Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader ## Changelog
vinylspiders
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Apr 15, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
vinylspiders
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Apr 15, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
vinylspiders
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Apr 16, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
vinylspiders
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Apr 16, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
Iajret
pushed a commit
to Fluffy-Frontier/FluffySTG
that referenced
this pull request
Apr 16, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
lessthnthree
pushed a commit
to effigy-se/effigy
that referenced
this pull request
Apr 19, 2025
## About The Pull Request Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now ## Why It's Good For The Game Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader ## Changelog
Shadow-Quill
pushed a commit
to Shadow-Quill/Bubberstation
that referenced
this pull request
Apr 30, 2025
## About The Pull Request Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now ## Why It's Good For The Game Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader ## Changelog
XeonMations
pushed a commit
to XeonMations/The-Final-Nights
that referenced
this pull request
May 4, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
Metekillot
pushed a commit
to Metekillot/TekquiemSS13
that referenced
this pull request
Jun 11, 2025
## About The Pull Request Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now ## Why It's Good For The Game Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader ## Changelog
siliconOpossum
pushed a commit
to siliconOpossum/MapleStationCode
that referenced
this pull request
Sep 13, 2025
Old project that I have been waiting on for some time. We can swap out our javascript bundler with a rust version. We still have webpack to some extent because sass-loader requests it, but it's unused. This was originally suggested by stylemistake years ago but it depended on tgui using a modern browser #90397 and rspack supporting yarn pnp web-infra-dev/rspack#7639. I want to also replace jest with vitest for this PR since it's deep internals and no one else is really tinkering here. Drafting for now Both of these tools are the drop in replacement of the modern decade Makes the dev server borderline instant https://rspack.dev/misc/faq#what-are-the-advantages-of-rspack-compared-to-webpack--swc-loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements the Yarn PnP feature and closes #2236. Special thanks to @arcanis for implementing PnP resolution in rspack_resolver.
Differences from Webpack Implementation
Intercepting FS on the Rust Side
A significant part of Webpack’s implementation is that it leverages PnP runtime to intercept all filesystem calls in Node.js via the .pnp.cjs file, correctly handling Yarn’s zip file paths as regular files. However, intercepting all filesystem calls on the JavaScript side incurs a significant performance cost in Rspack. Therefore, for performance reasons, Rspack intercepts standard filesystem calls in a custom native FS implementation in rust side.
Enabling PnP Only When resolve.enablePnp is Set
For performance optimization, Yarn PnP is enabled by default only when running in a PnP environment (when
process.versions.pnpis truthy). This avoids unnecessary overhead for users not utilizing Yarn PnP.Limitations
After discussions with @arcanis, supporting multiple Yarn PnP resolver instances would complicate the implementation and negatively impact cache efficiency. Since multiple PnP instances are rarely used in most Yarn PnP applications, Rspack supports only a single PnP resolver instance. Consequently, only the root
resolve.enablePnpsetting is effective, and settings within module.rule have no impact. This approach suffices for most Yarn PnP applications.Implementation Caveats
Yarn PnP requires filesystem interception for zip file calls, coupled the filesystem implementation with
resolve.enablePnPconfiguration. Introducing a rootenablePnPsetting might decouple the filesystem and resolver but could also add confusion and complexity to the configuration. Therefore, I have adhered to the current implementation.Checklist