Skip to content

fix: concatenation should merge module’s chunk init fragments #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: concatenation should merge module’s chunk init fragments #7504

merged 1 commit into from
Aug 8, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Aug 8, 2024

Summary

Following #7465.

When the module is concatenated, the chunk_init_fragments in codegen_res.data should be merged as well.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@fi3ework fi3ework requested a review from JSerFeng August 8, 2024 11:50
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 8, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e3e3b1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b4b0f47507fd000852ae65

@JSerFeng JSerFeng merged commit 6f19caa into web-infra-dev:main Aug 8, 2024
@fi3ework fi3ework deleted the shim-concat branch August 9, 2024 02:50
@chenjiahan chenjiahan mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @JSerFeng