Skip to content

fix(mf): retain all concatenated remote consumers - #15641

Merged
2heal1 merged 1 commit into
feat/mf-ssr-clear-cachefrom
fix/mf-concatenated-consumers
Sep 11, 2026
Merged

2heal1 merged 1 commit into
feat/mf-ssr-clear-cachefrom
fix/mf-concatenated-consumers

Conversation

@2heal1

@2heal1 2heal1 commented Sep 11, 2026

Copy link
Copy Markdown
Member

Motivation

Changes

@2heal1
2heal1 requested a review from ahabhgk as a code owner September 11, 2026 09:54
@2heal1
2heal1 merged commit fde17ba into feat/mf-ssr-clear-cache Sep 11, 2026
6 of 8 checks passed
@2heal1
2heal1 deleted the fix/mf-concatenated-consumers branch September 11, 2026 09:54
@github-actions

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 75fe8ff to fix(mf): retain shared dependencies during selective cache cleanup (#15614) by Hanric

⏳ The base commit triggered a linux binding build, but its binary size data has not been generated yet, so the size comparison is skipped.

Please re-run this workflow once the ecosystem-benchmark data for that commit is published.

Warning

Reference only — not the real baseline. The base commit's data isn't ready yet, so this compares against the nearest earlier commit that has data (f804acc) for a rough estimate:

❌ Size increased by 40.00KB from 68.58MB to 68.62MB (⬆️0.06%)

@codspeed

codspeed Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 3.41%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 49 untouched benchmarks
⏩ 47 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ rust@create_module_assets 149 µs 144.1 µs +3.41%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/mf-concatenated-consumers (75fe8ff) with feat/mf-ssr-clear-cache (8e63776)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on feat/mf-ssr-clear-cache (76e8f69) during the generation of this report, so 837a2df was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 523.6 KB - -
react-10k 5.3 MB 1.3 MB - -
react-1k 799.1 KB 217.5 KB - -
react-5k 2.6 MB 662.0 KB - -
ui-components 4.9 MB 1.4 MB - -
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.7 MB - -
🗜️ Gzip Size 523.6 KB - -
📄 JavaScript 1.7 MB - -
🎨 CSS 0 B - -
🌐 HTML 289.0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.3 MB - -
🗜️ Gzip Size 1.3 MB - -
📄 JavaScript 5.3 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 799.1 KB - -
🗜️ Gzip Size 217.5 KB - -
📄 JavaScript 798.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.6 MB - -
🗜️ Gzip Size 662.0 KB - -
📄 JavaScript 2.6 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 4.9 MB - -
🗜️ Gzip Size 1.4 MB - -
📄 JavaScript 4.8 MB - -
🎨 CSS 112.9 KB - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant