Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • strip ANSI codes from ignoreWarnings messages via util.stripVTControlCharacters to ensure that ignoreWarnings can more easily match warning message.
  • extract normalization function for ignoreWarnings option to make the code cleaner.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from hardfist as a code owner December 12, 2025 14:08
Copilot AI review requested due to automatic review settings December 12, 2025 14:08
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3ae4c52
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/693c21ff0fdf800008bdbafa

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Dec 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #12434 by stripping ANSI/VT control characters from warning messages before matching them against ignoreWarnings patterns, and refactors the normalization logic for better code organization.

  • Adds ANSI code stripping in IgnoreWarningsPlugin using Node.js's util.stripVTControlCharacters
  • Extracts ignoreWarnings normalization logic into a standalone function
  • Preserves warning objects by creating shallow copies with stripped messages

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/rspack/src/lib/IgnoreWarningsPlugin.ts Imports util module and strips VT control characters from warning messages before pattern matching
packages/rspack/src/config/normalization.ts Extracts normalizeIgnoreWarnings function to improve code organization and maintainability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 19c6cd719b | PR: #12432

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 3ae4c52 to chore: bump swc_experimental to fix parsing utf8 in template (#12431) by CPunisher

🙈 Size remains the same at 48.20MB

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025

CodSpeed Performance Report

Merging #12435 will not alter performance

Comparing warning_strip_1212 (3ae4c52) with main (6f3f4de)1

Summary

✅ 17 untouched

Footnotes

  1. No successful run was found on main (19c6cd7) during the generation of this report, so 6f3f4de was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Strip ANSI color codes from ignoreWarnings messages

2 participants