chore: rm unsued cached source #11754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of CachedSource wrapper around file_manifest.source when creating compilation assets, simplifying the asset creation process by directly using the source.
- Eliminates unnecessary
CachedSource::new(...).boxed()wrapper - Simplifies asset creation by passing source directly to
CompilationAsset::new
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
the
team
Contributor
📦 Binary Size-limit
🎉 Size decreased by 29.88KB from 47.85MB to 47.82MB (⬇️0.06%) |
CodSpeed Performance ReportMerging #11754 will not alter performanceComparing Summary
|
Contributor
|
📝 Benchmark detail: Open
|
SyMind
force-pushed
the
chore-rm-no-need-cached-source
branch
from
20dfacc to
e88ff46
Compare
SyMind
force-pushed
the
chore-rm-no-need-cached-source
branch
3 times, most recently
from
15b1ffb to
36ca351
Compare
SyMind
force-pushed
the
chore-rm-no-need-cached-source
branch
from
36ca351 to
6d9cad2
Compare
Contributor
ahabhgk
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the usage of
CachedSourcewrapper aroundfile_manifest.sourcewhen creating compilation assets, simplifying the asset creation process by directly using the source.CachedSource::new(...).boxed()wrapperCompilationAsset::newRelate PR: rstackjs/rspack-sources#183
This PR refactors
ReplaceSourceandCachedSourceto use trait objects (BoxSource) instead of generic type parameters, improving ergonomics and enabling runtime type checking. The key optimization checks if aBoxSourcealready wraps aCachedSourceto avoid double-caching.Key Changes:
ReplaceSource<T>andCachedSource<T>from generic structs to concrete structs usingBoxSourceCachedSource::new()to detect and unwrap existingCachedSourceinstancesoriginal()methods from both structs since the inner source is now a trait objectRelated links
Checklist