fix(template-react-ts): work with newer Node #10304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: On my machine running Node v23.11.0, running this example fails with two errors: 1. `__dirname` is undefined 2. `RefreshPlugin` is an object instead of a class This commit fixes both of these errors. Test Plan: 1. use Node v23.11.0 2. run `pnpm create rspack@latest` 3. select react-typescript config 4. run `pnpm run dev` Before this commit: it doesn't work After this commit: it works
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
github-actions
bot
added
the
release: bug fix
CodSpeed Performance ReportMerging #10304 will not alter performanceComparing Summary
|
chenjiahan
requested changes
May 9, 2025
|
related to nodejs/node#57298 (comment) and open-telemetry/opentelemetry-js#5415 it seems there's no ideal way to handle this right now, maybe we can generate different template for Node.js >23 |
|
@hardfist It seems that ts-node will have this problem. Rsbuild uses jiti and it works fine. |
|
Here is another issue with |
|
In the meantime I suggest we make two templates that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On my machine running Node v23.11.0, running this example fails with two errors:
__dirnameis undefinedRefreshPluginis an object instead of a classThis commit fixes both of these errors.
Test Plan:
pnpm create rspack@latestpnpm run devBefore this commit: it doesn't work
After this commit: it works