Skip to content

Conversation

@stormslowly
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 11, 2025 10:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds file dependency tracking for symlink-resolved files to ensure that real paths of symlink targets are properly recorded in the file dependencies context.

  • Updated the load_realpath method to accept a context parameter and track symlink-resolved file paths
  • Modified the resolve method call to use resolve_with_context for proper dependency tracking
  • Added test assertion to verify that resolved symlink paths are included in file dependencies

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/lib.rs Modified load_realpath to accept context and add resolved symlink paths to file dependencies
src/tests/symlink.rs Updated test to use context-aware resolution and verify dependency tracking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stormslowly stormslowly force-pushed the feat/add_real_file_with_symlinks branch from 3aedbbb to a4bc844 Compare October 11, 2025 10:08
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2025

CodSpeed Performance Report

Merging #108 will not alter performance

Comparing feat/add_real_file_with_symlinks (a4bc844) with main (1b359d5)

Summary

✅ 5 untouched

@stormslowly stormslowly merged commit 8124bf3 into main Oct 13, 2025
22 checks passed
@stormslowly stormslowly deleted the feat/add_real_file_with_symlinks branch October 13, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants