Skip to content

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Oct 11, 2025

it's easy to inspect difference between file and missing dependencies.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2025

CodSpeed Performance Report

Merging #107 will not alter performance

Comparing chore/add_enhanced_resolve_for_easy_compare (db321f1) with main (b5f9591)

Summary

✅ 5 untouched

@stormslowly stormslowly marked this pull request as ready for review October 11, 2025 03:10
Copilot AI review requested due to automatic review settings October 11, 2025 03:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a JavaScript example using enhanced-resolve to facilitate easy comparison with the existing Rust resolver implementation. The primary purpose is to enable inspection of differences between file and missing dependencies when resolving modules.

  • Added enhanced-resolve dependency to package.json for comparison purposes
  • Enhanced the existing Rust resolver example to output file and missing dependencies
  • Created a new JavaScript resolver example that mirrors the Rust functionality using enhanced-resolve

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Added enhanced-resolve dependency for comparison testing
examples/resolver.rs Updated to use resolve_with_context and output dependency tracking information
examples/resolve.js New JavaScript example using enhanced-resolve with similar functionality to the Rust version
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stormslowly stormslowly merged commit 1b359d5 into main Oct 11, 2025
21 checks passed
@stormslowly stormslowly deleted the chore/add_enhanced_resolve_for_easy_compare branch October 11, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants