Skip to content

fix: sdk types #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025
Merged

fix: sdk types #1058

merged 6 commits into from
Jun 19, 2025

Conversation

easy1090
Copy link
Contributor

Summary

fix: sdk types

Related Links

Copilot

This comment was marked as outdated.

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit 7527974
🔍 Latest deploy log https://app.netlify.com/projects/rsdoctor/deploys/68537c02adad0f00085a8b07
😎 Deploy Preview https://deploy-preview-1058--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@easy1090 easy1090 requested a review from 9aoy May 29, 2025 07:16
@easy1090 easy1090 requested a review from Copilot June 17, 2025 11:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines type imports in the test utilities to align with the SDK type definitions.

  • Changed path import to a namespace import for compatibility.
  • Updated MockSDKResponse.sdk to use the SDK.RsdoctorSDKInstance type.
Comments suppressed due to low confidence (1)

packages/sdk/tests/utils.ts:7

  • The RsdoctorSDK import is no longer used after updating the sdk field type; consider removing this import to eliminate dead code.
import { RsdoctorSDK } from '../src/sdk';

@easy1090 easy1090 merged commit db833cb into main Jun 19, 2025
7 of 8 checks passed
@easy1090 easy1090 deleted the fix/sdk-types branch June 19, 2025 03:39
@easy1090 easy1090 mentioned this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants