fix(fileSize): Avoid tiny gzip total diffs in file size reports#6720
Merged
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom Dec 7, 2025
Merged
fix(fileSize): Avoid tiny gzip total diffs in file size reports#6720chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes noisy file size reports by suppressing insignificant gzip total size differences. The change applies the existing isSignificantDiff threshold (10 bytes) to total gzip size differences, consistent with how individual file sizes and total uncompressed sizes are already handled.
Key Changes
- Modified gzip total diff display logic to use
isSignificantDiffinstead of showing all non-zero changes - Added a test to verify that gzip total diffs below the threshold are not displayed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/plugins/fileSize.ts | Applied significance check to total gzip size differences to prevent displaying tiny changes |
| e2e/cases/print-file-size/diff/index.test.ts | Added test case verifying that gzip total diffs below 10 bytes threshold are not displayed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The output for file size differences in gzip format included total differences even for very small changes, resulting in noisy logs for insignificant gzip shifts.
The significance check for total gzip size differences has been reused to ensure that only meaningful changes are displayed.
Related Links
Checklist