feat: refine size diff output for new files#6691
Merged
chenjiahan merged 2 commits intomainfrom Dec 3, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the file size diff output for new files in build reports. Previously, new files were displayed with a literal NEW marker, which was inconsistent with how size changes were displayed for existing files. Now, all files show numeric diffs, with new files calculated against a baseline of 0 kB.
- Simplified diff calculation logic to use 0 kB baseline for files without previous size data
- Updated documentation to reflect the new diff format and removed references to the "NEW" marker
- Changed
previousSizesparameter type to allownullwhen diff is disabled
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/plugins/fileSize.ts | Refactored diff calculation to use 0 baseline for new files; removed isNew flag and related logic; changed previousSizes type to FileSizeCache | null |
| website/docs/en/config/performance/print-file-size.mdx | Updated documentation to show numeric diffs for new files; removed sections explaining the "NEW" marker; reformatted code examples |
| website/docs/zh/config/performance/print-file-size.mdx | Applied formatting fixes to code examples for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change improves the readability and consistency of the build size report. Previously, new files were displayed with the literal marker
NEW. The diff is now calculated against a baseline of 0 kB, which makes new-file additions follow the same format as other size diffs.Using a numeric diff provides clearer feedback on bundle growth and avoids introducing a unique state in the size table.
Checklist