fix: print compilation error stacks in debug mode #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for printing compilation error stack traces when running in debug/verbose mode by configuring Rspack's stats.errorStack option.
Key changes:
- Enabled
errorStackin stats configuration when in verbose mode - Refactored error formatting to internalize verbose mode detection
- Added test coverage for the new functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/helpers/stats.ts | Added errorStack: isVerbose() to stats options and removed the now-unused verbose parameter from formatStatsError calls |
| packages/core/src/helpers/format.ts | Refactored formatStatsError to check verbose mode internally rather than accepting it as a parameter |
| e2e/helper/utils.ts | Added enableDebugMode utility function to simplify enabling debug mode in tests |
| e2e/cases/diagnostic/add-compilation-errors/ | New test case verifying error stack traces are shown in debug mode and hidden by default |
| e2e/cases/config/debug-mode/index.test.ts | Refactored to use the new enableDebugMode helper for cleaner test code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
errorStack: truetostats.toJson()to print compilation error stacks in debug mode:Related Links
Checklist