Skip to content

Conversation

@Deku-nattsu
Copy link
Contributor

rsbuild always prints the default 1:1 location even when loc is provided, this change fixes that by appending location to the file name before formatFileName is called

Copilot AI review requested due to automatic review settings November 9, 2025 16:21
@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8a60533
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/691151bcb6d6310008e214ef
😎 Deploy Preview https://deploy-preview-6540--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 54 (🔴 down 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds location information (line and column numbers) from the stats.loc field to the formatted error messages. When a StatsError contains location data, it will now be appended to the filename in the format :line:column.

  • Extracts location information from stats.loc field
  • Concatenates location to filename before formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) November 10, 2025 02:45
@chenjiahan chenjiahan disabled auto-merge November 10, 2025 03:39
@chenjiahan chenjiahan merged commit 35d0ec7 into web-infra-dev:main Nov 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants