Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Explain that loadBundle cannot be called within the onAfterDevCompile hook.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 9, 2025 02:31
@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 12be835
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690ffce91c6829000809496a
😎 Deploy Preview https://deploy-preview-6538--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 59 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation for the loadBundle method in the Environment API by providing more detailed explanations and important usage constraints.

  • Expanded the description of loadBundle to better explain its purpose and typical use cases
  • Added critical timing information about when loadBundle resolves (after build completion and onAfterDevCompile hook)
  • Documented the limitation that loadBundle cannot be called within the onAfterDevCompile hook

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/docs/en/api/javascript-api/environment-api.mdx Enhanced English documentation for loadBundle with detailed description and usage constraints
website/docs/zh/api/javascript-api/environment-api.mdx Enhanced Chinese documentation for loadBundle with detailed description and usage constraints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 6d67a40 into main Nov 9, 2025
18 checks passed
@chenjiahan chenjiahan deleted the load_bundle_doc_1109 branch November 9, 2025 02:34
@chenjiahan chenjiahan mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants