Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Track build status and errors in the internal context to provide better build state visibility. This is the basis for subsequent improvements to browser logs and assets middleware.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 27, 2025 08:40
@netlify
Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1291cfa
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68d7a5cc19435b0008352bb0
😎 Deploy Preview https://deploy-preview-6268--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 26 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds build state tracking to the internal context to provide better visibility into the build status and error state. The changes introduce new types for tracking build status and integrate build state updates throughout the compilation lifecycle.

  • Introduces new BuildStatus and BuildState types to track compilation state
  • Adds build state tracking to the internal context with initialization
  • Updates compiler hooks to maintain build status and error state throughout the compilation process

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/types/context.ts Defines new build state types and adds buildState property to InternalContext
packages/core/src/createContext.ts Initializes buildState with default idle status and no errors
packages/core/src/provider/createCompiler.ts Integrates build state updates into compiler lifecycle hooks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 2b2263a into main Sep 27, 2025
11 checks passed
@chenjiahan chenjiahan deleted the internal_context_build_state_0927 branch September 27, 2025 12:53
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants