Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Add test cases for Vue runtime error logging to verify error forwarding to terminal.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 26, 2025 09:49
@netlify
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 4f43bd9
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68d6619e877b2c00083c23ea
😎 Deploy Preview https://deploy-preview-6262--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds end-to-end test cases to verify that Vue runtime errors are properly forwarded from the browser to the terminal during development. The tests cover two common error scenarios: accessing properties of undefined variables and calling methods on null objects.

  • Creates Vue components that intentionally trigger runtime errors
  • Tests error forwarding for both render-time and event-handler errors
  • Validates that error messages appear in the terminal with correct formatting

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
e2e/cases/browser-logs/vue-error/src/undefinedError.js Entry point for testing undefined property access errors
e2e/cases/browser-logs/vue-error/src/eventError.js Entry point for testing event handler errors
e2e/cases/browser-logs/vue-error/src/UndefinedError.vue Vue component that triggers undefined property access error
e2e/cases/browser-logs/vue-error/src/EventError.vue Vue component that triggers null method call error in click handler
e2e/cases/browser-logs/vue-error/rsbuild.config.ts Configuration file setting up Vue plugin and multiple entry points
e2e/cases/browser-logs/vue-error/index.test.ts Test file verifying error forwarding behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@chenjiahan chenjiahan merged commit 2922267 into main Sep 26, 2025
12 checks passed
@chenjiahan chenjiahan deleted the vue_error_logs_0926 branch September 26, 2025 23:23
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants