Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • Add test cases for preserve JSX runtime mode
  • Update test descriptions to be more concise

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 24, 2025 13:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test cases for preserve JSX runtime mode and standardizes test descriptions by making them more concise. The changes primarily focus on testing React JSX runtime configurations and improving test readability.

  • Add comprehensive test coverage for preserve JSX runtime mode including new test files and configuration
  • Update test descriptions across multiple files to use shorter, more consistent naming (e.g., "in dev" instead of "in development correctly")
  • Replace legacy JSX test with classic JSX runtime test to better reflect current testing needs

Reviewed Changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.

File Description
e2e/cases/plugin-react/jsx-runtime-preserve/ New test case for preserve JSX runtime with complete React app setup
e2e/cases/plugin-react/jsx-runtime-classic/index.test.ts New test for classic JSX runtime replacing legacy JSX test
e2e/cases/plugin-react/legacy-jsx/index.test.ts Removed legacy JSX test file
Multiple test files Updated test descriptions to be more concise and consistent

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 6 to 8
expect(
(await content).includes('<div id="test">Hello Rsbuild!</div>'),
).toBeTruthy();
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses around await content are unnecessary. The await operation has higher precedence than the method call, so this can be simplified to expect((await content).includes('<div id="test">Hello Rsbuild!</div>')).toBeTruthy(); or better yet, use a more specific assertion like expect(await content).toContain('<div id="test">Hello Rsbuild!</div>');

Suggested change
expect(
(await content).includes('<div id="test">Hello Rsbuild!</div>'),
).toBeTruthy();
expect(await content).toContain('<div id="test">Hello Rsbuild!</div>');

Copilot uses AI. Check for mistakes.
@netlify
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f4483be
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68d3f3f6175d2e0008e236d1
😎 Deploy Preview https://deploy-preview-6243--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 14 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan merged commit 62012e2 into main Sep 24, 2025
11 checks passed
@chenjiahan chenjiahan deleted the e2e_jsx_preserve_0924 branch September 24, 2025 13:47
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants