Repository navigation
Conversation
🦋 Changeset detectedLatest commit: d02ca90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 119 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Rsdoctor Bundle Diff Analysis📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 bundle-diffPath:
📦 Download Diff Report: bundle-diff Bundle Diff Generated by Rsdoctor GitHub Action |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A real MF SSR playground exposed aborted responses after a dynamic lazy remote had resolved: the ready callback entered the response setup twice, and React rejected the second
pipe()withReact currently only supports piping to one writable stream.The resulting premature close made raw SSR requests fail even though browser hydration could display the remote.Guard Node response-pipeline startup before scheduling template work. Re-entered ready callbacks reuse the already-started pipeline; cancellation and producer tracking remain in place. Add a deterministic regression using real React streams with a re-entered all-ready callback, and a patch changeset.
Validation
pnpm --filter @modern-js/runtime exec rstest tests/ssr/streamLifecycle.test.tsx: all 18 tests pass.pnpm --filter @modern-js/runtime run build: passed.pnpm exec biome checkon both changed TypeScript files andgit diff --check: passed.Unrelated runtime/router suites and the full framework build were not repeated; this change is confined to Node stream startup. Targets the SSR integration branch as requested.