Skip to content

Fix build with C++20 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristelmerilain merged 2 commits into from
Oct 15, 2024
Merged

Fix build with C++20 #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9465a8b
Fix build with C++20
metsma Oct 10, 2024
4539418
Merge branch 'main' into cpp20
metsma Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions include/electronic-id/enums.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class CertificateType
bool isSigning() const { return value == SIGNING; }

constexpr bool operator==(const CertificateType other) const { return value == other.value; }
constexpr bool operator!=(const CertificateType other) const { return value != other.value; }
operator std::string() const;

private:
Expand Down Expand Up @@ -73,7 +72,6 @@ class HashAlgorithm
HashAlgorithm(const std::string&);

constexpr bool operator==(HashAlgorithmEnum other) const { return value == other; }
constexpr bool operator!=(HashAlgorithmEnum other) const { return value != other; }
constexpr operator HashAlgorithmEnum() const { return value; }

operator std::string() const;
Expand Down Expand Up @@ -146,14 +144,9 @@ class SignatureAlgorithm

constexpr bool operator==(HashAlgorithm other) const
{
return operator HashAlgorithm() == other;
}
constexpr bool operator!=(HashAlgorithm other) const
{
return operator HashAlgorithm() != other;
return other.operator ==(operator HashAlgorithm());
}
constexpr bool operator==(SignatureAlgorithmEnum other) const { return value == other; }
constexpr bool operator!=(SignatureAlgorithmEnum other) const { return value != other; }

constexpr operator HashAlgorithm() const
{
Expand Down Expand Up @@ -190,7 +183,6 @@ class JsonWebSignatureAlgorithm
}

constexpr bool operator==(JsonWebSignatureAlgorithmEnum other) const { return value == other; }
constexpr bool operator!=(JsonWebSignatureAlgorithmEnum other) const { return value != other; }
constexpr operator JsonWebSignatureAlgorithmEnum() const { return value; }

operator std::string() const;
Expand Down