Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe calls and deprecation fixed #470

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Safe calls and deprecation fixed #470

merged 6 commits into from
Sep 8, 2023

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Sep 7, 2023 •
edited
Loading

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky Spomky self-assigned this Sep 7, 2023
@Spomky Spomky added the bug Something isn't working label Sep 7, 2023
@Spomky Spomky added this to the 4.7.1 milestone Sep 7, 2023
This was linked to issues Sep 7, 2023
Deprecation of setters decreases safety and developer experience #464
Closed
JsonException: Malformed UTF-8 characters #465
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@Spomky Spomky changed the base branch from 4.7.x to 4.8.x September 8, 2023 08:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@Spomky Spomky changed the base branch from 4.8.x to 4.7.x September 8, 2023 08:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

70.2% 70.2% Coverage
24.2% 24.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Spomky Spomky merged commit 8128dff into 4.7.x Sep 8, 2023
@Spomky Spomky deleted the safe-calls branch September 8, 2023 10:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.2% 70.2% Coverage
24.3% 24.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Spomky Spomky

Labels
bug Something isn't working
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

JsonException: Malformed UTF-8 characters Deprecation of setters decreases safety and developer experience
1 participant
@Spomky