fix: return transports in attestation response pk credential source #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Spomky I fixed the styling issue from the tests. However, the Rector tests that are failing are not related to any changes I made. I could fix them, but I think it's better to create a separate PR for that. |
|
Hi, Many thanks for this PR.
Rector/ECS issues will be fixed before the release of this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.7.x
Resolves issue: n/a
The PublicKeyCredentialSource from the AuthenticatorAttestationResponseValidator was always returning an empty array for transports. This PR fixes that and adds the transports as given in the AuthenticatorAttestationResponse. This change breaks the constructor signature of AuthenticatorAttestationResponse by adding an additional parameter.
Tests are adjusted accordingly.