Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #433

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Fix typos #433

merged 2 commits into from
Jul 15, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 2, 2023

Target branch: 4.7.x

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

This files starts with ->set('webauthn.cose.algorithm.manager') (note the "h")
@Spomky What effect does it have?

@Spomky
Copy link
Contributor

Spomky commented Jul 2, 2023

🫢
I do not see any effect on the tests, but as the service name changes, this could break the applications that are using the old name.
Perhaps having an alias with the old name and marked as deprecated could help.

Example:

$container
    ->setAlias('webauthn.cose.algorithm.RS256', 'webauthn.cose.algoritm.RS256')
    ->setDeprecated(....)
;

@Spomky Spomky self-assigned this Jul 2, 2023
@Spomky Spomky added this to the 4.7.0 milestone Jul 2, 2023
@szepeviktor
Copy link
Contributor Author

This is too 🌶️ for viktor!
I leave it 💯% up to you.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 2, 2023

You may run https://github.com/crate-ci/typos in CI.

.typos.toml

[files]
extend-exclude = [
    "tests/metadataServices/",
    "tests/blob.jwt"
]
[default]
extend-ignore-re = [
    "'\\{\"id\":\".+\\}';",
    "'\\[\\{\".+\"\\}\\]';",
    "'\\{\".+\"\\}';",
    "'\\{\".+\\}'",
    "'eHouz_Zi7-BmByHjJ_[A-Za-z0-9_-]+'",
    "\"attestationObject\": \"[A-Za-z0-9_-]+\",",
    "'mMihuIx9Luks[A-Za-z0-9_-]+'",
    "\"Exemple FIDO2 authenticator de FIDO Alliance\""
]
[default.extend-words]
cose = "cose"
[default.extend-identifiers]
"baDesc" = "baDesc"
"getBaDesc" = "getBaDesc"

@Spomky Spomky merged commit fb38183 into web-auth:4.7.x Jul 15, 2023
@Spomky
Copy link
Contributor

Spomky commented Jul 15, 2023

Many thanks!

@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the fix-typos branch July 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants