Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused symfony/process dependency #235

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Remove unused symfony/process dependency #235

merged 1 commit into from
Jun 22, 2022

Conversation

TimWolla
Copy link
Contributor

Q A
Branch? 4.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Symfony\Component\Process does not appear to be referenced anywhere, making this a useless dependency.

@TimWolla
Copy link
Contributor Author

Apparently CI does not run for PRs. The GitHub Action workflows should likely be fixed to include pull_request in addition to push.

@Spomky Spomky merged commit 4dcbe56 into web-auth:v4.0 Jun 22, 2022
@Spomky
Copy link
Contributor

Spomky commented Jun 22, 2022

Many thanks.
This package was used for the certificate checks, but this part was simplified in the last version and I forgot removing it.

@TimWolla TimWolla deleted the patch-1 branch June 29, 2022 09:56
@TimWolla
Copy link
Contributor Author

Hi @Spomky: Can you release a new version for this, please? I'd like to avoid needing to ship these dependencies in our non-Symfony application.

@TimWolla
Copy link
Contributor Author

Awesome, thank you!

@Spomky
Copy link
Contributor

Spomky commented Jul 21, 2022

I'm sorry I totally missed the tagging and splitting last changes.
It's now done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants