Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe #149

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Safe #149

merged 2 commits into from
Jul 21, 2020

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Jul 21, 2020

No description provided.

@Spomky Spomky merged commit 767e13b into v3.3 Jul 21, 2020
@Spomky Spomky deleted the Safe branch July 21, 2020 23:29
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@guardrails
Copy link

guardrails bot commented Jul 21, 2020

⚠️ We detected security issues in this pull request:

Insecure File Management (9)

file_put_contents($untrustedFilename, PHP_EOL, FILE_APPEND);

fwrite($resource, $data);

file_put_contents($trustedFilename, $certificate, FILE_APPEND);


file_put_contents($untrustedFilename, $certificate, FILE_APPEND);

file_put_contents($leafFilename, $leafCertificate);



file_put_contents($trustedFilename, PHP_EOL, FILE_APPEND);

More info on how to fix Insecure File Management in PHP.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@ildyria
Copy link

ildyria commented Dec 10, 2020

This is breaking any PHP 8 build relying on dev (as there is no stable branch providing PHP 8 support yet).

@Spomky
Copy link
Contributor Author

Spomky commented Dec 11, 2020

Hi @ildyria,

PHP8 support will be fixed in v3.3
See https://github.com/web-auth/webauthn-framework/actions/runs/415425926 and https://github.com/web-auth/webauthn-framework/actions/runs/415425928 (failing test will be corrected soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants