Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete certificate chain verification #137

Merged
merged 49 commits into from
Dec 6, 2020

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Jun 20, 2020

No description provided.

The Webauthn\PublicKeyCredentialLoader resvice cannot be created because of a missing dependency
@Spomky Spomky added the enhancement New feature or request label Jun 20, 2020
@Spomky Spomky added this to the Version 3.3 milestone Jun 20, 2020
@Spomky Spomky self-assigned this Jun 20, 2020
@Spomky Spomky linked an issue Jun 20, 2020 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@guardrails
Copy link

guardrails bot commented Jul 21, 2020

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Spomky added 19 commits July 22, 2020 01:49
# Conflicts:
#	src/symfony/tests/functional/MetadataService/ConformanceTest.php
#	src/webauthn/src/AuthenticatorAttestationResponseValidator.php
#	src/webauthn/src/CertificateToolbox.php
# Conflicts:
#	composer.json
#	phpunit.xml.dist
#	src/metadata-service/src/MetadataService.php
# Conflicts:
#	composer.json
#	phpunit.xml.dist
#	src/metadata-service/src/MetadataService.php
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 21, 2020
# Conflicts:
#	src/webauthn/src/PublicKeyCredentialDescriptorCollection.php
@stale stale bot removed the wontfix This will not be worked on label Nov 22, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@Spomky Spomky merged commit 9b70c49 into v3.3 Dec 6, 2020
@Spomky Spomky deleted the CompleteCertificateChainVerification branch December 6, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhanced Metadata Repository and Metadata Statement verification
2 participants