PublicKeyCredentialRpEntity.name deprecated, but clients require rp.name

[ronaldpk]

According to the deprecation message, in 5.3 the name property should be left empty when creating the PublicKeyCredentialRpEntity.

$rpEntity = PublicKeyCredentialRpEntity::create(
    name: '',
    id: 'sub.example.com'
);

That way, the JSON that gets sent back to the client has an rp that only has the id property.

{
	"challenge":"random bytes here",
	"rp":{
		"id":"sub.example.com"
	},
	"user":{
		"id":"A random, 16-byte value generated per account",
		"name":"user@example.com",
		"displayName":""
	},
	...
}

The problem is that clients require the rp to have a name property. Otherwise FF and Vivaldi throw errors like "CredentialsContainer.create: Missing required 'name' member of PublicKeyCredentialEntity."

Or am I overlooking something?

[ronaldpk]

Apparently it is SimpleWebAuthn that is being picky about the rp name, as described in commit 911fcea . As a workaround I'm now simply setting $rpEntity->name = 'sub.example.com'. Thank you.