AndNot: materialize results directly into arena slots#48
Merged
Conversation
containerAndNotAlt gains a non-inline mode that fills a caller-sized slot in place (bitmap or compact array, selected by len(dst)); pass 2 reserves the slot and drops the separate repacking helpers. Enumeration is split into typed *IntoArray methods and array framing shares setArrayHeader. No behavior change; ~6% faster HeavyShrink, ~3% Dense, allocations unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Trust the container cardinality header in andNotResultCard instead of popcounting bitmap sources: the bc==nil/empty and bitmap-array cases now read the header, with a floor-based early exit for the latter. Inline the dense check, fold nil/empty into one guard, and drop the corrupt-header test that pinned the old count-by-bits behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aliszka
force-pushed
the
perf/andnot-materialize
branch
from
e10f24a to
9924606
Compare
amourao
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerAndNotAlt gains a non-inline mode that fills a caller-sized slot in place (bitmap or compact array, selected by len(dst)); pass 2 reserves the slot and drops the separate repacking helpers.
Enumeration is split into typed *IntoArray methods and array framing shares setArrayHeader.
No behavior change; ~6% faster HeavyShrink, ~3% Dense, allocations unchanged.