feat: support dynamic user management in Weaviate v1.30#369
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
- create_users - update_users - delete_users
We do not want to risk breaking existing applications, as currently 404 response code does not produce a WeaviateError.
Deprecate assignedUsersGetter in the async client.
antas-marcin
reviewed
Apr 9, 2025
antas-marcin
reviewed
Apr 9, 2025
src/main/java/io/weaviate/client/v1/async/users/api/common/AssignedRolesGetter.java
Show resolved
Hide resolved
antas-marcin
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings support for dynamic user management features introduced in
v1.30.Adds (sync/async):
DbUsersandOidcUsersclients accessible viaclient.users().db()andclient.users().oidc()UserAssignemntsGetterto retrieve uses assigned to the role from /user-assignments endpointResultconstructor that allows to override the body while reusing the HTTP responseResult.voidToBooleanhelpers now accept a list of allowed failure codes that still should producetruein the resultResultRoleAssignerandRoleRevokerto take an optional namespace argument. This allows re-using the existing classes for legacy, db-, and oidc- users.Deprecates (sync/async):
assigner,revoker, anduserRolesGetteron the rootUsersclient (not namaspaced)assignedUsersGetterinRolesclient (in favor ofuserAssignmentsGetter)Updates: