Skip to content

fix(experimental): make metadata fields public #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bevzzz merged 1 commit into from
Mar 7, 2025
Merged

fix(experimental): make metadata fields public #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/io/weaviate/client/v1/experimental/SearchResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ public static class SearchObject<T> {
@AllArgsConstructor
@ToString
public static class SearchMetadata {
String id;
Float distance;
Float[] vector;
public final String id;
public final Float distance;
public final Float[] vector;
}
}
}
11 changes: 11 additions & 0 deletions src/test/java/io/weaviate/integration/client/grpc/GRPCBenchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import org.apache.commons.lang3.ArrayUtils;
import org.apache.commons.lang3.time.DateFormatUtils;
import org.apache.commons.lang3.time.DateUtils;
import org.assertj.core.api.Assertions;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.ClassRule;
Expand Down Expand Up @@ -190,6 +191,16 @@ public void testORMClient() {

int count = countGRPC(result);
assertEquals(K, count, String.format("must return K=%d results", K));

Assertions.assertThat(result.objects).allSatisfy(
object -> {
Assertions.assertThat(object.metadata.id)
.isNotNull().as("must retrieve id");
Assertions.assertThat(object.metadata.vector)
.isNotNull().as("must retrieve vector")
.hasSize(VECTOR_LEN).as("vector has expected size");
});

}, WARMUP_ROUNDS, BENCHMARK_ROUNDS);
}

Expand Down