feat(ColBERT): Create, update, batch insert, and query objects with multi-vector indices #356
Merged
feat(ColBERT): Create, update, batch insert, and query objects with multi-vector indices #356
Conversation
This commit: - Provides MultiVectorConfig to enable multi-vector indices in collections - Registers custom deserializer for WeaviateObject with Gson - Extends GRPC utilities to (de-)serialize 2-dimensional float arrays to/from ByteString
Extended WeaviateObject.Adapter to also implement JsonSerializer.
Fixed some bugs in the custom serializer introduced previously.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
antas-marcin
reviewed
Mar 3, 2025
src/main/java/io/weaviate/client/v1/graphql/query/argument/NearVectorArgument.java
Outdated
Show resolved
Hide resolved
antas-marcin
reviewed
Mar 3, 2025
src/main/java/io/weaviate/client/v1/graphql/query/argument/NearVectorArgument.java
Outdated
Show resolved
Hide resolved
antas-marcin
reviewed
Mar 3, 2025
src/main/java/io/weaviate/client/v1/graphql/query/argument/NearVectorArgument.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 1 0 0 |
View in Orca |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
|
net.minidev:json-smart | ./pom.xml | CVE-2024-57699 | 2.5.1 | 2.5.2 | View in code |
antas-marcin
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
This PR adds supports for ColBERT embeddings / multi-vectors.
Notable changes:
MultiVectorConfigFloat[][]vectors (byteopspackage as a reference implementation)WeaviateObjectwhich merges named vectors and named "multi-vectors" to"vectors"fieldNote, that WeaviateObject does not have a
Float[][] vectorfield, as Weaviate only expects 1d-vectors under"vector".How is this tested: