Skip to content

Just show the untruncated label in the tooltip on children #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2016
Merged

Just show the untruncated label in the tooltip on children #911

merged 1 commit into from
Feb 3, 2016

Conversation

paulbellamy
Copy link
Contributor

Fixes #908

@paulbellamy
Copy link
Contributor Author

@davkal, ptal

@davkal
Copy link
Contributor

davkal commented Feb 3, 2016

Works as advertised, but we lose useful data on hover, like theadcount, parentPID, full command, etc.
So maybe we should be more careful about the metadata that is added to a child node, @paulbellamy ?

@paulbellamy
Copy link
Contributor Author

I feel like if you want that information you should click on the link to view the full node details. The tooltip is strictly for disambiguation.

@davkal
Copy link
Contributor

davkal commented Feb 3, 2016

Fair enough. LGTM

paulbellamy added a commit that referenced this pull request Feb 3, 2016
@paulbellamy
Merge pull request #911 from weaveworks/908-shorter-child-tooltips
2ed3968 
Just show the untruncated label in the tooltip on children
@paulbellamy paulbellamy merged commit 2ed3968 into master Feb 3, 2016
@paulbellamy paulbellamy deleted the 908-shorter-child-tooltips branch February 3, 2016 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @davkal