Skip to content

Defer metrics registration until we need it #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Defer metrics registration until we need it #3605

merged 1 commit into from
Jul 16, 2019

Conversation

bboreham
Copy link
Collaborator

This avoids app-specific metrics appearing in the probe.

fbarl
fbarl approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

qiell
qiell approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bboreham
Defer metrics registration until we need it
89363f5 
This avoids app-specific metrics appearing in the probe.
@bboreham bboreham force-pushed the defer-metrics-registration branch from 129cbfb to 89363f5 Compare July 4, 2019 14:25
@bboreham bboreham merged commit 26c8760 into master Jul 16, 2019
@bboreham bboreham deleted the defer-metrics-registration branch July 16, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

@qiell qiell qiell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @fbarl @qiell