Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce theme fonts #3177

Merged
merged 2 commits into from
May 18, 2018
Merged

Enforce theme fonts #3177

merged 2 commits into from
May 18, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 17, 2018

Scope part of weaveworks/ui-components#212.

Uses Proxima Nova as a default font instead of Roboto.

Not to be merged before https://github.com/weaveworks/service-ui/pull/2551.

@fbarl fbarl self-assigned this May 17, 2018
@fbarl fbarl requested a review from foot May 17, 2018 09:06
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Terminal is still using courier-new
  • Do we already have a license for proxima-nova?

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment.

@fbarl
Copy link
Contributor Author

fbarl commented May 18, 2018

Terminal is still using courier-new

I added a commit that changes that :) Unfortunately, overriding the default font family didn't really work so I needed to hack the css styles..

Do we already have a license for proxima-nova?

I think @bowenli is looking into that right now - in any case, it's a problem for a future PR.

@fbarl fbarl merged commit 5e700d9 into master May 18, 2018
@fbarl fbarl deleted the 212-enforce-theme-fonts branch May 18, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants